• Melissa Zhang's avatar
    [Sharesheet] Don't override OnWidgetBoundsChanged · 06a2e07d
    Melissa Zhang authored
    OnWidgetBoundsChanged is invoked when the bounds of the widget
    changes, but was being used to indicate the bounds of its parent
    had changed. This was creating a bug when SharesheetBubbleView was
    updating to the NearbyShare view as the change in widget size was
    invoking OnWidgetBoundsChanged and causing the anchor position to
    update. Moving the anchor position stopped the NearbyShare view
    from animating, causing the view to only fill a portion of the
    sharesheet. Instead of overriding OnWidgetBoundsChanged, we call
    UpdateAnchorPosition directly when we observe a change in the
    bounds of the parent widget.
    
    Bug: 1152651
    Change-Id: Ieeda8ceeb577fd0ce43a98550ac437a1ac4fad11
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616643
    Commit-Queue: Melissa Zhang <melzhang@chromium.org>
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Auto-Submit: Melissa Zhang <melzhang@chromium.org>
    Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#841355}
    06a2e07d
sharesheet_bubble_view.cc 25.8 KB