• Manu Cornet's avatar
    CrOS shelf: Hide tooltip between launcher button and 1st shelf item · 0748bf4e
    Manu Cornet authored
    Shelf items used to be aligned directly after the launcher button,
    so it made sense to include everything within bounds where tooltips
    should not hide to avoid hiccups.
    
    However, now that we show centered shelf items, this means that a
    tooltip can be shown all over a possibly quite large amount of white
    space between the launcher button and the first shelf item.
    
    1) It is very strange to show a tooltip over such a potentially large
    piece of shelf. 2) On the other hand, when it does happen that the
    first shelf item is close to the launcher button, not showing a
    tooltip in the space between them does mean a slight stutter when
    hovering from one to the next.
    
    The drawbacks of 1) clearly outweigh the ones of 2), so this change
    hides tooltips between the launcher button and the first shelf item.
    
    Bug: 896524
    Change-Id: I06e666ba0296881f87c2cf3ce5972b38d638c3f7
    Reviewed-on: https://chromium-review.googlesource.com/c/1393889
    Commit-Queue: Manu Cornet <manucornet@chromium.org>
    Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#619727}
    0748bf4e
shelf_view_unittest.cc 144 KB