• Joel Hockey's avatar
    Reland "Support Arc, crostini, and Plugin VM in drag drop FileHelper" · 0758c369
    Joel Hockey authored
    This reverts commit 8fd7b85d.
    
    Reason for revert: relanding after creating fix for M88
    
    Original change's description:
    > Revert "Support Arc, crostini, and Plugin VM in drag drop FileHelper"
    >
    > This reverts commit 54e85384.
    >
    > Reason for revert: Reverting in order to create a patch for M88.
    >
    > Original change's description:
    > > Support Arc, crostini, and Plugin VM in drag drop FileHelper
    > >
    > > The current code in FileHelper assumes all windows are Arc. We now
    > > check the source and target aura::Window to detect and do the
    > > appropriate path translations and share files when necessary with
    > > crostini/pluginvm.
    > >
    > > For example, when crostini is the drag source, we will convert paths
    > > such as:
    > >
    > >  <homedir>/file => /media/fuse/crostini_<hash>_termina_penguin/file
    > >
    > > And do the opposite translation when crostini is the drop target.
    > >
    > > We also convert paths and share files such as:
    > >
    > >  <cryptohome>/MyFiles/file => /mnt/chromeos/MyFiles/file
    > >  /media/removable/MyUSB => /mnt/chromeos/removable/MyUSB
    > >
    > > For PluginVM, the translation is
    > >
    > >  <cryptohome>/MyFiles/file => //ChromeOS/MyFiles/file
    > >  /media/removable/MyUSB => //ChromeOS/removable/MyUSB
    > >
    > > Bug: 1144138
    > > Change-Id: I2bb38336537acf13c4797374d6dabe6e518d689e
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517346
    > > Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    > > Reviewed-by: Jason Lin <lxj@google.com>
    > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#827956}
    >
    > TBR=oshima@chromium.org,joelhockey@chromium.org,niwa@chromium.org,lxj@google.com
    >
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    >
    > Bug: 1144138
    > Change-Id: I212ae8759e9069e52837fd1bc324ea5f9046b6b5
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547743
    > Reviewed-by: Joel Hockey <joelhockey@chromium.org>
    > Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    > Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#829031}
    
    TBR=oshima@chromium.org,joelhockey@chromium.org,niwa@chromium.org,lxj@google.com
    
    # Not skipping CQ checks because this is a reland.
    
    Bug: 1144138
    Change-Id: I0a735fb4e17679f735c11ecab427f7ba624db399
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547844Reviewed-by: default avatarJoel Hockey <joelhockey@chromium.org>
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#829065}
    0758c369
crostini_util.h 8.66 KB