• Mostyn Bramley-Moore's avatar
    drop unnecessary realpath usage in the FindBadConstructs plugin · 07b2231e
    Mostyn Bramley-Moore authored
    All we need to do is ensure that there's a leading '/' in the path, we
    don't expect the path to exist necessarily, and we don't need to resolve
    symlinks.  We just want to be able to search for directories by doing a
    string search of the form "/foo/".  And since we don't use realpath
    anymore, this should work with distributed compilation systems like icecc.
    
    This will also avoid mis-classification of files in chromium checkouts
    that are inside a directory with the same name as one of the so-called
    "banned" directories, eg a checkout in /home/gen/chromium/.
    
    BUG=583454
    
    Change-Id: I01f6417eadf88f0e6d29624014573022e29093ff
    Reviewed-on: https://chromium-review.googlesource.com/975041
    Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
    Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#546769}
    07b2231e
FindBadConstructsAction.cpp 2.06 KB