• Robbie Gibson's avatar
    Revert "Fix NTP omnibox animation when there are suggestions" · 07e1c27a
    Robbie Gibson authored
    This reverts commit 2aa19d70.
    
    Reason for revert: Breaks QR code scanner. In investigating that, I think I found a better solution.
    
    Original change's description:
    > Fix NTP omnibox animation when there are suggestions
    > 
    > Before, if there were suggestions on the NTP, they would immediately
    > appear. The better animation is to scroll the fakebox up to the top
    > of the screen and then present the suggestions.
    > 
    > To do this, when entering the omnibox from NTP, we only focus the
    > location bar, which causes the scrolling animation. -fakeboxFocused
    > is already called in the animation completion block, which does the
    > actual work to make the omnibox text field first responder, causing the
    > suggestions to appear.
    > 
    > To finish off, the -locationBarDidBecomeFirstResponder code now only
    > focuses the location bar if we are not on the regular NTP.
    > 
    > Bug: 1057643
    > Change-Id: I472ee1ee5693fa4102717275bf266f4ab97e121a
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082556
    > Commit-Queue: Robbie Gibson <rkgibson@google.com>
    > Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#746450}
    
    TBR=stkhapugin@chromium.org,gambard@chromium.org,rkgibson@google.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1057643
    Change-Id: Ifda283f7733b9439e3803d1110b0afefeee084f6
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089782Reviewed-by: default avatarRobbie Gibson <rkgibson@google.com>
    Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
    Commit-Queue: Robbie Gibson <rkgibson@google.com>
    Cr-Commit-Position: refs/heads/master@{#747710}
    07e1c27a
fakebox_focuser.h 919 Bytes