• Elly Fong-Jones's avatar
    cocoa: prompt for in-progress incognito downloads at quit · 08757f1e
    Elly Fong-Jones authored
    The code in [AppController shouldQuitWithInProgressDownloads] needs to account
    for the fact that incognito profiles have separate DownloadManagers from their
    parent profiles. This change does this by considering incognito profiles as
    though they were regular profiles.
    
    1) Create a profile, create an incognito window from it, start a download,
       quit Chrome: a "cancel download?" prompt should now appear.
    2) Create a profile, create an incognito window from it, quit Chrome: no
       "cancel download?" prompt should appear.
    3) Create a profile, start a download, quit Chrome: a "cancel download?" prompt
       should appear as before.
    4) Create a profile, quit Chrome: no "cancel download?" prompt should appear.
    
    Bug: 88419
    Test: Manual
    Change-Id: Ib25995c45ae99f3b1fe00b15a37108399be06f77
    Reviewed-on: https://chromium-review.googlesource.com/895802
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#533290}
    08757f1e
app_controller_mac.mm 66.1 KB