• Lukasz Anforowicz's avatar
    Avoid leaking NavigationRequest when committing an error page. · 087c0606
    Lukasz Anforowicz authored
    Sometimes the commit IPC really is for |navigation_request_| even when
    the URL checks at the top of RFHI::TakeNavigationHandleForCommit
    indicate a mismatched URL.  Examples of when this can happen are XFO
    checks (see https://crbug.com/870815) and CSP/frame-ancestors checks
    (see https://crbug.com/759184).
    
    Before this CL, in the cases above |navigation_request_| would be
    leaked.  This CL fixes the leak.
    
    Bug: 872803
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.perf:obbs_fyi
    Change-Id: Ia09f355e69f182479386b3deeea1f7f0c8996813
    Reviewed-on: https://chromium-review.googlesource.com/1169865
    Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
    Reviewed-by: default avatarAlex Moshchuk <alexmos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582289}
    087c0606
render_frame_host_impl.cc 228 KB