• Henrique Ferreiro's avatar
    Reland "Fix loading of animated cursors on Ozone/Wayland" · 089795b2
    Henrique Ferreiro authored
    This is a reland of dcee7502 after
    fixing https://crbug.com/1139157.
    
    The hidden cursor needs to be obtained from the CursorFactory, even if
    platform cursors are disabled and the Chromium assets are used instead
    (i.e. Chrome OS).
    
    This reland also fixes the original CL in that it accidentally reverted
    https://crrev.com/c/2443610.
    
    Original change's description:
    > Fix loading of animated cursors on Ozone/Wayland
    >
    > Animated cursor assets were not being loaded because GetCursorDataFor
    > was used for all cursors, instead of using GetAnimatedCursorDataFor when
    > the cursor was animated.
    >
    > With this CL, both set of cursors are merged so they can be retrieved
    > with a single call.
    >
    > To ease these changes, ImageCursor, which was a very thin layer over
    > CursorLoader, was merged into the latter. This change has the benefit of
    > unifying the cursor loading code path of Ash with the one of the other
    > Aura platforms and changing Ash on Linux to use the Chromium assets
    > instead of the platform cursors, as when running on Chrome OS devices.
    >
    > The only behavior change with respect to ImageCursors is that the cached
    > cursors will be removed on display changes, instead of reloaded.
    >
    > Bug: 1135515
    > Change-Id: Iedf84290bf3792c3ce06cfad0be1b5c0e2d96946
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440760
    > Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
    > Reviewed-by: Scott Violet <sky@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#815678}
    
    Bug: 1135515, 1139157
    Change-Id: I2bfff067936b1ec8e828c5efdfb0a9c24caf7afc
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478977
    Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
    Reviewed-by: default avatarScott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#819330}
    089795b2
native_cursor_manager_ash.cc 5.08 KB