GitLab

Currently we have

  CastSocket::OnOpenCallBack 
    = base::OnceCallback<void(int channel_id, ChannelError error_state)>. 

We need to call 

  CastSocket* socket = cast_socket_service_->GetSocket(channel_id); 

to get socket object in callback function, which seems unnecessary.

Make CastSocket::OnOpenCallback take CastSocket* parameter instead. Callback is invoked 
by CastSocket object with 'this' pointer. Since CastSocket only runs on the IO thread, so
do callback functions, no post task is involved, raw pointer seems safe.

Resolve code review comments for: https://chromium-review.googlesource.com/c/575247

Bug: 749762
Change-Id: Iaab109774fa2c67d99a7fa5afffdf2315b32fd59
Reviewed-on: https://chromium-review.googlesource.com/590588
Commit-Queue: Bin Zhao <zhaobin@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491423}