• siyua's avatar
    Return .PreviouslyAccepted and .PreviouslyDenied data to parent histograms · 08cc9254
    siyua authored
    The Autofill.CreditCardInfoBar.Server histogram was split into {
    	Autofill.CreditCardInfoBar.Server,
    	Autofill.CreditCardInfoBar.Server.PreviouslyDenied,
    	Autofill.CreditCardInfoBar.Server.PreviouslyAccepted}.
    
    This caused confusion as it went against precedent where sub-histograms
    shouldn't affect their parent's data, and as a result hid a lot of data
    behind the .PreviouslyAccepted and .PreviouslyDenied subhistograms.
    
    Here's what we want to happen instead, using
    Autofill.CreditCardInfoBar.Server as an example:
    1) Autofill.CreditCardInfoBar.Server goes back to containing ALL data,
    not just a portion of it.
    2) What used to go to Autofill.CreditCardInfoBar.Server should now go to
    Autofill.CreditCardInfoBar.Server.NoPreviousDecision so that the
    subhistograms are still useful.
    
    
    
    
    Bug: 827414
    Change-Id: I432e98f4729318e3e060e280551286b2bcfb80b0
    Reviewed-on: https://chromium-review.googlesource.com/997026
    Commit-Queue: Siyu An <siyua@chromium.org>
    Reviewed-by: default avatarEvan Stade <estade@chromium.org>
    Reviewed-by: default avatarSebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: default avatarJared Saul <jsaul@google.com>
    Cr-Commit-Position: refs/heads/master@{#550100}
    08cc9254
histograms.xml 4.16 MB
The source could not be displayed because it is larger than 1 MB. You can load it anyway or download it instead.