• Peter Kasting's avatar
    Misc. cleanup in advance of drag-and-drop fixes: · 08dbcae9
    Peter Kasting authored
    * Use =default more
    * Use in-declaration initialization more
    * Use inequality forms of expects/asserts over e.g. ASSERT_TRUE(a == b)
    * Use temps to avoid subepxr repetition
    * Use ui_test_utils::GetCenterInScreenCoordinates() more
    * Prefer EXPECT to ASSERT where failing the expectation wouldn't crash
    * TestTargetView::Init() is called after being added to the view hierarchy
      and thus can use parent()
    * Make overrides match the access control level of the parent declaration
    * git cl format
    * Update comments slightly
    * Don't bother caching things in ToolbarViewInteractiveUITest that can be
      computed on the fly
    * SetUpCommandLine() should be used to actually tweak the command line,
      other setup can be done from SetUpOnMainThread()
    * No need to reset browser flags and such during interactive UI test
      teardown, since interactive UI tests always tear down the whole process
    
    Bug: none
    Change-Id: I5a7ca34b4c59ff12a17f163466c5af76815cb329
    Reviewed-on: https://chromium-review.googlesource.com/c/1478372
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Auto-Submit: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: default avatarScott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#633885}
    08dbcae9
interactive_test_utils_views.cc 1.57 KB