-
Findit authored
This reverts commit 638ab304. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 601431 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzYzOGFiMzA0MDhjZmNkOTk3MDM5MTYwYzVmZmIxMjZjNWE4MmVmZjMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ASan%20LSan%20Tests%20%281%29/51310 Sample Failed Step: content_unittests Original change's description: > AppCache: clean up WeakPtrFactory members in classes with children. > > This CL marks AppCache clases with WeakPtrFactory members as final, and > removes WeakPtrFactory members from classes that have subclasses. > > The superclasses of AppCache classes with WeakPtrFactory members were > checked for WeakPtrFactory members, resulting in minor cleanups. > > This CL does not tackle AppCacheUrlRequestJob, because net:URLRequestJob > (which has a WeakPtrFactory) has 35 subclasses. This case will be > addressed separately. > > TBR=kinuko > > Change-Id: I04bb0757c34fa03620517d04571cba5a0e4a77a5 > Reviewed-on: https://chromium-review.googlesource.com/c/1267337 > Commit-Queue: Victor Costan <pwnall@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601431} Change-Id: I61dd61aee9e5289784403ebfb085c90809d25cde No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1293044 Cr-Commit-Position: refs/heads/master@{#601438}
b796d00e