• Yuheng Huang's avatar
    Reland "Tab Search: Setup keyboard shortcut" · 092c72a9
    Yuheng Huang authored
    Cause of revert: The previous CL tried to add a key to
    accelerators_cocoa.mm without adding to menu item
    Solution: remove change in accelerators_cocoa.mm but keep the change in
    global_keyboard_shortcuts_mac.mm
    
    This is a reland of 9b3d32d9
    
    Original change's description:
    > Tab Search: Setup keyboard shortcut
    >
    > Setup ctrl(cmd on Mac) + shift + e as tab search keyboard shortcut
    > for all desktop platforms
    >
    > Bug: 1099917,1112558
    > Change-Id: I6c50b26714d678d0f89d2c846909ff0b802e4f0d
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329944
    > Commit-Queue: Yuheng Huang <yuhengh@chromium.org>
    > Reviewed-by: Scott Violet <sky@chromium.org>
    > Reviewed-by: Robert Liao <robliao@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#795750}
    
    Bug: 1099917
    Bug: 1112558
    Change-Id: I4639649e6b0b839ead06aac1458c058f20db5fca
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343300Reviewed-by: default avatarScott Violet <sky@chromium.org>
    Commit-Queue: Yuheng Huang <yuhengh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#796584}
    092c72a9
global_keyboard_shortcuts_mac.mm 10.5 KB