-
jmadill authored
Revert of Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS (patchset #17 id:310001 of https://codereview.chromium.org/2124633002/ ) Reason for revert: Seems to break the Android and Linux GPU fyi bots: https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%205X%29/builds/1098 https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28ATI%29/builds/48671 https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%206P%29/builds/1004 <couple others> GpuProcess.no_transparent_visuals_gpu_process Failure: disable_transparent_visuals is missing in Browser process workarounds: [u'broken_egl_image_ref_counting', u'clear_uniforms_before_first_program_use', u'disable_blend_equation_advanced', u'disable_chromium_framebuffer_multisample', u'disable_depth_texture', u'disable_discard_framebuffer', u'disable_framebuffer_cmaa', u'disable_program_cache', u'force_cube_map_positive_x_allocation', u'max_copy_texture_chromium_size_1048576', u'max_texture_size_limit_4096', u'scalarize_vec_and_mat_constructor_args', u'unbind_attachments_on_bound_render_fbo_delete', u'unbind_egl_context_to_flush_driver_caches', u'use_virtualized_gl_contexts', u'wake_up_gpu_before_drawing'] [ FAILED ] GpuProcess.no_transparent_visuals_gpu_process (5860 ms) Original issue's description: > Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS > > This is for better polish in the UI but it fixes a drag > image issue on Linux crbug.com/593256 . > > Also add a kGpuDriverBugListJson entry to automatically > disable transparent visuals on all drivers (especially > the proprietary NVIDIA driver) except for opensource > drivers (i.e. Mesa based drivers). > > BUG=369209 > > R=kbr@chromium.org, sadrul@chromium.org, tapted@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/71b2517dd4cd620a56ca6f13571129c6aee30b42 > Cr-Commit-Position: refs/heads/master@{#406505} TBR=kbr@chromium.org,sadrul@chromium.org,tapted@chromium.org,piman@chromium.org,j.isorce@samsung.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=369209 Review-Url: https://codereview.chromium.org/2171023002 Cr-Commit-Position: refs/heads/master@{#407047}
096fa27c
