GitLab

The refactoring introduced in crrev.com/c/653037 introduced a new
main file for simple client that included client_base.h.

The memory layout of ClientBase depends on the define OZONE_PLATFORM_GBM.
On ozone gbm platform, when building wayland_simple_client, the define
would be present while building simple.cc but no when building simple_main.cc.

This meant that the allocated layout for Simple would be different than
the memory layout expected by the ctor, and it caused surprising bugs.

This CL renames the define OZONE_PLATFORM_GBM to USE_GBM and moves it to
a public_configs of client_support. In this way any target depending on
client_support will build with that define.

Additionally, this CL adds explicit minigbm dependencies where needed.

Bug: 
Test: wayland_simple_client stopped behaving in unexpected ways.
Change-Id: I17327b47b4ac3cac889d0452467c453ecc1ec165
Reviewed-on: https://chromium-review.googlesource.com/690804
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505264}