• Prabir Pradhan's avatar
    Reland "Exo: Undo conflation of relative-pointer and pointer-constraints" · 09a954f4
    Prabir Pradhan authored
    This reverts commit 9189f6dd.
    
    Reason for revert: This CL is unrelated to the test that is was suspected of making flaky.
    
    Original change's description:
    > Revert "Exo: Undo conflation of relative-pointer and pointer-constraints"
    > 
    > This reverts commit 01116522.
    > 
    > Reason for revert: suspected of causing
    > PointerLockBrowserTestWithOptions.UnadjustedMovement to be flaky
    > 
    > See bug: 1043985
    > 
    > Original change's description:
    > > Exo: Undo conflation of relative-pointer and pointer-constraints
    > > 
    > > When it was first implemented, adding a relative-pointer-delegate would
    > > also enable pointer capture (locking the pointer).
    > > 
    > > This change makes it so that the pointer can only be locked through the
    > > pointer-constraints protocol.
    > > 
    > > Bug: b/124059008
    > > Test: exo_unittests, manual testting using ArcPointerCaptureTestApp
    > > Change-Id: Ied0f1c658aa713026e622f4ce26009e261d4f653
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992355
    > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    > > Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org>
    > > Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#733497}
    > 
    > TBR=mukai@chromium.org,oshima@chromium.org,prabirmsp@chromium.org
    > 
    > Change-Id: I8581f298f099cb7a9a006a1b578f6345184da1d3
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: b/124059008
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012517
    > Reviewed-by: Nina Satragno <nsatragno@chromium.org>
    > Commit-Queue: Nina Satragno <nsatragno@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#733612}
    
    TBR=mukai@chromium.org,oshima@chromium.org,nsatragno@chromium.org,prabirmsp@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: b/124059008
    Change-Id: I5e0c6615b9dce0c48f94d6b227763cfc205954b4
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015301Reviewed-by: default avatarMitsuru Oshima <oshima@chromium.org>
    Reviewed-by: default avatarNina Satragno <nsatragno@chromium.org>
    Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org>
    Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#734655}
    09a954f4
zwp_relative_pointer_manager.cc 3.57 KB