• Maksim Orlovich's avatar
    Reland "Adjust tests for upcoming cross-site cookie requirements" · 09c4f971
    Maksim Orlovich authored
    This reverts commit a88c5fe6.
    
    Reason for reland: The test was/is flaky on that bot in the first place,
                       the name change just makes it look different.
    
    Original change's description:
    > Revert "Adjust tests for upcoming cross-site cookie requirements"
    >
    > This reverts commit 83b71438.
    >
    > Reason for revert: SitePerProcessSSLBrowserTest.UnloadHandlersArePowerful*
    > failing on Android. Please see bug.
    >
    > Bug: 1014956
    > Original change's description:
    > > Adjust tests for upcoming cross-site cookie requirements
    > >
    > > They will need to be marked explicitly and secure, so adjust some tests to
    > > be over SSL and mark those cookies appropriately
    > >
    > > Bug: 1006816
    > > Change-Id: I6da53ea64a7c03530335913fadb9099992e8ca33
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863389
    > > Reviewed-by: Avi Drissman <avi@chromium.org>
    > > Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#706108}
    >
    > TBR=avi@chromium.org,morlovich@chromium.org
    >
    > Change-Id: I982bc1590171f92883000c8315d3be77f7b35b9f
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 1006816
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865249
    > Reviewed-by: Parastoo Geranmayeh <parastoog@google.com>
    > Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
    > Cr-Commit-Position: refs/heads/master@{#706453}
    
    TBR=avi@chromium.org,parastoog@google.com,morlovich@chromium.org
    
    Change-Id: I51c863c89ade36edddc4b1b7a3f16d82c9f855f3
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1014956, 1006816
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866614Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
    Reviewed-by: default avatarMaksim Orlovich <morlovich@chromium.org>
    Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#707918}
    09c4f971
site_per_process_unload_browsertest.cc 63 KB