• Andrew Grieve's avatar
    Revert "Android: Use turbine to generate java headers" · 09ca64de
    Andrew Grieve authored
    This reverts commit 55ab173a.
    
    Reason for revert: Suspect breaking coverage bots:
    https://bugs.chromium.org/p/chromium/issues/detail?id=1062704
    
    Original change's description:
    > Android: Use turbine to generate java headers
    >
    > See go/faster-javac for a detailed analysis of why turbine was chosen to
    > speed up our java builds. The current implementation is an initial
    > implementation that can be further optimized. It already gives savings
    > of 10-30% of our java incremental builds depending on the target in
    > question (see go/project-turbo for timing details).
    >
    > This implementation does remove some of the benefits of the previous way
    > that java_library_impl was implemented, namely when a target's
    > .interface.jar file changes, it no longer short-circuits dependent
    > targets from being built since we now use group(target_name). This is
    > arguably more correct as prebuilts depend on javac jars directly. In the
    > future (after the androidx migration and other build improvements) this
    > can be improved by having prebuilts depend on the interface jars
    > instead.
    >
    > Bug: 1056299
    > Change-Id: I49d18604203749cf447ce77c54a8f8469c83eae1
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105415
    > Commit-Queue: Peter Wen <wnwen@chromium.org>
    > Auto-Submit: Peter Wen <wnwen@chromium.org>
    > Reviewed-by: Andrew Grieve <agrieve@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#750651}
    
    TBR=wnwen@chromium.org,agrieve@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1056299, 1062704
    Change-Id: Ib3ad0b0a40a25c949775fdef786ad6d776c2c684
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108791Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
    Commit-Queue: Andrew Grieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#751467}
    09ca64de
rules.gni 184 KB