• Antonio Sartori's avatar
    Remove no-op if from RFHImpl::DidCommitNavigation · 09fb9ba1
    Antonio Sartori authored
    RenderFrameHostImpl::DidCommitNavigation is called either by
    (1) DidCommitPerNavigationMojoInterfaceNavigation or (2)
    DidCommitProvisionalLoad.
    
    (1) always passes a committing_navigation_request (there is a CHECK
    just before calling DidCommitNavigation that the navigation has been
    found in the map navigation_requests_).
    
    (2) moves into committing_navigation_request the navigation_request_ of
    the RFH, hence making navigation_request_ null.
    
    Hence this if statement is a no-op and can be eliminated.
    
    Change-Id: Iae99e84c4d127c679001598ead84a061a16cf515
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426615
    Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
    Reviewed-by: default avatarArthur Sonzogni <arthursonzogni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#810124}
    09fb9ba1
render_frame_host_impl.cc 389 KB