• Peter Mayo's avatar
    Compile failure on Google%20Chrome%20Win · 0a301aa2
    Peter Mayo authored
    Revert "[chrome_elf, third-party block support] Pass file path in registry."
    
    This reverts commit ea1974d4.
    
    Reason for revert: <INSERT REASONING HERE>
    
    Original change's description:
    > [chrome_elf, third-party block support] Pass file path in registry.
    > 
    > Due to rare case of install_static::GetUserDataDir() path expansion,
    > this API cannot be used inside DllMain().  The full, expanded path to
    > the packed blacklist file will be dropped into install_static::GetRegistryPath(),
    > in the kThirdPartyRegKeyName subkey, in the kBlFilePathRegValue REG_SZ value.
    > This has no other impact on existing functionality.
    > 
    > - This change includes comments, constants, and tests.
    > 
    > - LogLoadAttempt() will now include the section path for any 'blocked' logs
    > as well.  Friendly reminder that log.AddEntry() will still not add duplicate
    > 'blocked' logs, to protect against spammy logging.
    > 
    > - Removed old bit of uninstaller touching old blacklist.
    > 
    > Test: chrome_elf_unittests.exe, ThirdParty*
    > Bug: 769590
    > Change-Id: Id9ada49215aa110db9fb72a4712da9d3fb7ccf31
    > Reviewed-on: https://chromium-review.googlesource.com/1109600
    > Reviewed-by: Robert Shield <robertshield@chromium.org>
    > Reviewed-by: Tom Sepez <tsepez@chromium.org>
    > Commit-Queue: Penny MacNeil <pennymac@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#570849}
    
    TBR=robertshield@chromium.org,tsepez@chromium.org,pennymac@chromium.org
    
    Change-Id: I8f734013213e0fa1e1321e3b573172ed9a85a649
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 769590
    Reviewed-on: https://chromium-review.googlesource.com/1117399Reviewed-by: default avatarPeter Mayo <petermayo@chromium.org>
    Commit-Queue: Peter Mayo <petermayo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#570857}
    0a301aa2
logs.cc 8.89 KB