• Marc Treib's avatar
    Reland "Sync: Use IdentityManager instead of SigninManager" · 0a3600c1
    Marc Treib authored
    This reverts commit fd8a3a1f.
    
    Reason for revert: The depended-on CL has been relanded as https://crrev.com/c/1030451
    
    Original change's description:
    > Revert "Sync: Use IdentityManager instead of SigninManager"
    > 
    > This reverts commit aab57914.
    > 
    > Reason for revert: Depends on crrev.com/c/1025898 which was reverted
    > 
    > Original change's description:
    > > Sync: Use IdentityManager instead of SigninManager
    > > 
    > > This CL migrates ProfileSyncService to IdentityManager for getting
    > > info on the primary account. This includes switching from
    > > SigninManagerBase::Observer to IdentityManager::Observer.
    > > The only remaining use of SigninManager within PSS it to call
    > > SignOut() which isn't exposed by IdentityManager yet.
    > > 
    > > Bug: 825190
    > > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    > > Change-Id: Icf9398d63794cab03cb559adba5c767e18c31c0a
    > > Reviewed-on: https://chromium-review.googlesource.com/983914
    > > Commit-Queue: Marc Treib <treib@chromium.org>
    > > Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#553973}
    > 
    > TBR=blundell@chromium.org,treib@chromium.org,mastiz@chromium.org
    > 
    > Change-Id: Ib40dbff0f1c8e5fba95cb9881681361abec5aeec
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 825190, 837201
    > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    > Reviewed-on: https://chromium-review.googlesource.com/1030372
    > Reviewed-by: Marc Treib <treib@chromium.org>
    > Commit-Queue: Marc Treib <treib@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#553997}
    
    TBR=blundell@chromium.org,treib@chromium.org,mastiz@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 825190, 837201
    Change-Id: If6858f033ac8390acfc904379afbf9726a6301c2
    Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Reviewed-on: https://chromium-review.googlesource.com/1043885Reviewed-by: default avatarMarc Treib <treib@chromium.org>
    Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#556026}
    0a3600c1
sync_service_base.cc 6.9 KB