• Dana Fried's avatar
    Revert "Move installer.cc file to updater/win directory." · 0a8c6b81
    Dana Fried authored
    This reverts commit e1f49aca.
    
    Reason for revert: Breaks build - linker error (see bug)
    
    Bug: 1165994
    
    Original change's description:
    > Move installer.cc file to updater/win directory.
    >
    > The installer API code is Windows-specific and it would be desirable
    > to isolate //chrome/updater from its implementation details.
    >
    > This change uses public_deps and visibility to make
    > updater:lib and updater/win:lib act as a unit, to resolve the issue
    > of the circular includes as suggested by the GN documentation.
    >
    > Bug: 1014630
    >
    > Change-Id: Ib47dc9041af08651549d0feaf35790f336dfe193
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588508
    > Commit-Queue: Sorin Jianu <sorin@chromium.org>
    > Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#842765}
    
    TBR=sorin@chromium.org,waffles@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
    
    Change-Id: I0acf2fce533e34424465c4ce65202a53881feb4d
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1014630
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626351Reviewed-by: default avatarDana Fried <dfried@google.com>
    Commit-Queue: Dana Fried <dfried@google.com>
    Cr-Commit-Position: refs/heads/master@{#842780}
    0a8c6b81
BUILD.gn 3.74 KB