• Philip Rogers's avatar
    Disable BlinkGenPropertyTrees by default · 0a942fb1
    Philip Rogers authored
    Due to existing regressions, this patch disables BlinkGenPropertyTrees.
    
    For completeness (to prevent another http://crbug.com/935195), tested:
    +------------------------------------------------+-----------+------------+
    |                      flag                      | pre-patch | post-patch |
    +------------------------------------------------+-----------+------------+
    |                     no flag                    | BGPT on   |  BGPT on*  |
    | --enable-features=BlinkGenPropertyTrees        | BGPT on   |  BGPT on   |
    | --disable-features=BlinkGenPropertyTrees       | BGPT off  |  BGPT off  |
    | --enable-blink-features=BlinkGenPropertyTrees  | BGPT on   |  BPGT on   |
    | --disable-blink-features=BlinkGenPropertyTrees | BGPT off  |  BGPT off  |
    +------------------------------------------------+-----------+------------+
    * This is due to the finch field trial testing config.
    
    content/child/runtime_features.cc now checks for experimental web platform
    features because the BlinkGenPropertyTrees flag is fully controlled by the
    feature default in third_party/blink/common/features.cc and would be disabled
    in web tests (formerly layout tests) without this check.
    
    Bug: 836884
    Change-Id: I590e1b7c697c7c70cf3c4c5121483b2dd76c74df
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505836Reviewed-by: default avatarXianzhu Wang <wangxianzhu@chromium.org>
    Reviewed-by: default avatarDmitry Gozman <dgozman@chromium.org>
    Commit-Queue: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#638706}
    0a942fb1
runtime_features.cc 20.7 KB