• joi@chromium.org's avatar
    Implement ability to specify temporarily-allowed dependencies in DEPS · 0aa12e03
    joi@chromium.org authored
    files, and use this ability in a few DEPS files where appropriate.
    This has no effect on the normal running of checkdeps; "!"
    dependencies are treated just like "+" dependencies when checkdeps is
    run on our bots.
    
    An upcoming change will use the new checkdeps.CheckAddedIncludes
    function, and will error out if you add a new include that violates a
    "-" rule, and show a presubmit warning when you add a new include that
    violates a "!" rule (the warning will say something like "We are in
    the process of removing dependencies from this directory to that file,
    can you avoid adding more?"
    
    While I was in there, fixed path handling so that checkdeps will work
    on case-sensitive platforms with paths that include upper-case
    characters (e.g. a checkout of Chrome at ~/c/Chrome/src rather than
    ~/c/chrome/src).
    
    Since the pipes.quote method seems unreliable on Windows (it failed on
    my setup), switched to subprocess.list2cmdline which I believe is
    stable.
    
    Added a small manual testing mode to checkdeps.  It currently only
    verifies the CheckAddedIncludes function.
    
    TBR=jam@chromium.org
    BUG=138280
    
    Review URL: https://chromiumcodereview.appspot.com/10805042
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149163 0039d316-1c4b-4281-b951-d872f2087c98
    0aa12e03
DEPS 722 Bytes