• sky@chromium.org's avatar
    Revert 284459 "Add FailureValue and wire it through PageTestResu..." · 0b249ecd
    sky@chromium.org authored
    Reverting in hopes of getting android telemetry_perf_unittests to
    green. Here's output:
    http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14733/steps/telemetry_perf_unittests/logs/stdio
    
    Unhandled exception while running file://scrollable_page.html
    
    Traceback (most recent call last):
      _RunPage at tools/telemetry/telemetry/page/page_runner.py:533
        test.RunPage(page, page_state.tab, results)
      RunPage at tools/telemetry/telemetry/page/page_test.py:228
        self.WillRunActions(page, tab)
      WillRunActions at tools/perf/measurements/smoothness.py:26
        self._power_metric.Start(page, tab)
      Start at tools/perf/metrics/power.py:77
        self._browser.platform.StartMonitoringPower(self._browser)
      StartMonitoringPower at
      tools/telemetry/telemetry/core/platform/__init__.py:193
        self._platform_backend.StartMonitoringPower(browser)
      StartMonitoringPower at
      tools/telemetry/telemetry/core/platform/android_platform_backend.py:251
        self._powermonitor.StartMonitoringPower(browser)
      StartMonitoringPower at
      tools/telemetry/telemetry/core/platform/power_monitor/android_temperature_monitor.py:31
        self._power_monitor.StartMonitoringPower(browser)
      StartMonitoringPower at
      tools/telemetry/telemetry/core/platform/power_monitor/power_monitor_controller.py:29
        self._active_monitor.StartMonitoringPower(browser)
      StartMonitoringPower at
      tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py:33
        'Must call StopMonitoringPower().')
    AssertionError: Must call StopMonitoringPower().
    
    
    > Add FailureValue and wire it through PageTestResults.
    > 
    > BUG=392901
    > 
    > Review URL: https://codereview.chromium.org/399263003
    
    TBR=chrishenry@google.com
    
    Review URL: https://codereview.chromium.org/393713005
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284497 0039d316-1c4b-4281-b951-d872f2087c98
    0b249ecd
skpicture_printer_unittest.py 1.29 KB