• Arthur Sonzogni's avatar
    Revert "Report was_cached in SubresourceLoadInfo" · 0b2b1a92
    Arthur Sonzogni authored
    This reverts commit d46ddaea.
    
    Reason for revert: 2 tests are failing with NavigationMojoResponse.
    See https://crbug.com/822237
    The two failing are disabled with the NetworkService.
    I can't fix the reverted CL. It has removed URLLoaderCompletionStatus.exists_in_cache and rely on NavigationURLLoaderNetworkService::OnResponseStarted to memorize if the response is in the cache.
    In a lot of cases when NavigationURLLoaderDelegate::OnRequestFailed() is called, NavigationURLLoaderNetworkService::OnResponseStarted() is not called. It means |has_stale_copy_in_cache| will be set to false even if the failed request is in cache.
    
    Original change's description:
    > Report was_cached in SubresourceLoadInfo
    > 
    > This change adds a boolean `was_cached` to the SubresourceLoadInfo
    > struct.  This lets consumers know whether or not the response was
    > fetched from the network cache.  Notably, this is important for
    > recording page load metrics when the Network Service is enabled.
    > 
    > BUG=816684
    > 
    > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
    > Change-Id: I28d60ff7286feca5d333203405ee9c351f43c0ab
    > Reviewed-on: https://chromium-review.googlesource.com/938650
    > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Reviewed-by: Jay Civelli <jcivelli@chromium.org>
    > Commit-Queue: Conley Owens <cco3@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#543276}
    
    TBR=dcheng@chromium.org,jcivelli@chromium.org,jam@chromium.org,cco3@chromium.org
    
    Change-Id: I23b197839b9b35af7d79ed03320a7494635c61bf
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 816684
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
    Reviewed-on: https://chromium-review.googlesource.com/964461Reviewed-by: default avatarArthur Sonzogni <arthursonzogni@chromium.org>
    Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#543375}
    0b2b1a92
appcache_url_loader_job.cc 12.1 KB