• dominickn's avatar
    Properly fall back to manifest short_name when name is empty. · 0b543dd3
    dominickn authored
    If a PWA includes a "name" field in their manifest, but explicitly sets
    it to the empty string, it would have an app banner displayed with no
    text, as well as no title on its splash screen.
    
    This CL fixes the bug by properly checking if the "name" string is
    empty, rather than just null. This check is already performed by the
    InstallableManager in the process of determining whether or not a site
    is a valid PWA. An additional test is added to ensure the correct
    functionality.
    
    BUG=722615
    
    Review-Url: https://codereview.chromium.org/2900623002
    Cr-Commit-Position: refs/heads/master@{#473806}
    0b543dd3
app_banner_manager.cc 18.7 KB