• Moe Ahmadi's avatar
    Revert "[AF] Do not discard form data after dynamic form submission" · 0b6da642
    Moe Ahmadi authored
    This reverts commit e93874be.
    
    Reason for revert: http://crbug.com/863954#c3
    
    Original change's description:
    > [AF] Do not discard form data after dynamic form submission
    > 
    > Prior to this change form data were being discarded after a dynamic form
    > submission. This was because the dynamically changed form was being added
    > to the cache with its user entered/autofilled values. At the time of
    > submission, form data were being discarded as they were thought to be the
    > initial values of the fields at page load. This CL changes
    > AutofillHandler::OnFormsSeen (which is called on dynamic form changes) to
    > attempt to find a previously cached version of the form first. Prior to
    > addition to the cache, form values are overridden by the cached values.
    > This prevents those values from getting confused with the initial form
    > values at the time of submission.
    > 
    > Bug: 863954
    > 
    > Change-Id: Iba4771ee87b9777e66a6b10b6b369379dc123a46
    > Reviewed-on: https://chromium-review.googlesource.com/1137021
    > Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
    > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#577033}
    
    TBR=sebsg@chromium.org,mahmadi@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 863954
    Change-Id: I71d0970d10fe1d4857e98ba558b9253b13ad053d
    Reviewed-on: https://chromium-review.googlesource.com/1151911Reviewed-by: default avatarMoe Ahmadi <mahmadi@chromium.org>
    Reviewed-by: default avatarSebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#579858}
    0b6da642
autofill_uitest_util.cc 3.2 KB