GitLab

Revert of Reland https://codereview.chromium.org/298333007/: Enable mac_strip_release under ASan on OSX. Remo… (patchset #1 id:1 of https://codereview.chromium.org/517803004/)

Reason for revert:
Breaks *lots* of browser_tests on Mac ASan. See e.g.:
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Mac%20ASan%2064%20Tests%20%281%29&number=2036
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Mac%20ASan%2064%20Tests%20%282%29&number=2600
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Mac%20ASan%2064%20Tests%20%283%29&number=2424

Original issue's description:
> Reland https://codereview.chromium.org/298333007/: Enable mac_strip_release under ASan on OSX. Remove the .saves files.
>
> The reasons for reverting the CL hadn't been documented. I'm going to reland and update the bugs.
>
> Unce upon a time the ASan runtime library used to be statically linked into
> the executables on OSX.
> Because that library provided a number of API functions needed by the shared
> libraries, we had custom ASan-specific .saves files that told the `strip`
> utility to preserve those functions when stripping the executables.
>
> Then ASan switched to using dynamic runtime library, which instantly broke the
> stripping step, because the executables weren't necessarily referencing all the
> ASan API functions (issue 242503).
> As a result, stripping has been disabled, and we haven't had .dSYM debug info
> for ASan builds for more than a year now (issue 148383).
>
> Because the ASan API functions are now undefined in the executables, it's
> actually senseless to use the .saves files to preserve those functions.
> This CL deletes the .saves files and turns mac_strip_release on for ASan
> builds.
>
> BUG=148383, 242503, 170739, 166857
> TBR=mark@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/d5319a149964f953e7506c1ff2b33f90974d19ea

TBR=mark@chromium.org,glider@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=148383, 242503, 170739, 166857

Review URL: https://codereview.chromium.org/522743003

Cr-Commit-Position: refs/heads/master@{#292885}