• David Staessens's avatar
    Revert "media/gpu/test: Change DCHECKS to CHECKS in video decoder test code." · 0c1995de
    David Staessens authored
    This reverts commit 3c8fa0a5.
    
    Reason for revert: This change breaks the DecodeAccelSanityVP91 test.
    The CHECKS also don't print the associated message in release builds, but only
    "Trace/breakpoint trap (core dumped)" which makes them useless.
    
    Original change's description:
    > media/gpu/test: Change DCHECKS to CHECKS in video decoder test code.
    >
    > This CL changes some of the DCHECKS in the video_decode_accelerator_(perf_)tests
    > code to CHECKS, so they are also performed in release builds. This will make it
    > easier to debug some test-related issues.
    >
    > Ideally we would use the dcheck_always_on GN argument, but as the tests are
    > build as part of the Chrome binary this would greatly increase Chrome build time
    > as most libraries would have to be build twice.
    >
    > TEST=./video_decode_accelerator_tests on eve
    >
    > BUG=905520
    >
    > Change-Id: I207abf4d53a5a3d1d5684fd5cd2a045e401bc9ad
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826297
    > Commit-Queue: David Staessens <dstaessens@chromium.org>
    > Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#703581}
    
    TBR=acourbot@chromium.org,dstaessens@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 905520, 1013439
    Change-Id: I56cb5bb2cb7496d993e0fd3015cd7dc8c4a11add
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855141
    Commit-Queue: David Staessens <dstaessens@chromium.org>
    Reviewed-by: default avatarDavid Staessens <dstaessens@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#704949}
    0c1995de
video_frame_helpers.cc 14 KB