• Elad Alon's avatar
    Fix WebRtcEventLogUploaderImpl::Cancel() · 0cd49d1a
    Elad Alon authored
    Prior to this CL, Cancel() returned a confusing boolean, which was
    supposed to be used to indicate whether the `WebRtcEventLogUploaderImpl`
    could be deleted directly, or if the caller to Cancel() was supposed to
    wait for the completion callback to be posted back to it.
    
    Instead, we now always wait for the completion callback to be
    posted back.
    
    Note that we also introduce a check to ensure the callback belongs
    to the currently uploaded file, rather than to the previously
    uploaded file.
    
    Bug: 1092071
    Change-Id: I7dd92d806bef540125bcafb49b57d763783c64eb
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260637
    Commit-Queue: Elad Alon <eladalon@chromium.org>
    Reviewed-by: default avatarGuido Urdaneta <guidou@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#781977}
    0cd49d1a
webrtc_event_log_uploader.cc 15.2 KB