• Thomas Anderson's avatar
    Revert "Proactively purging discardable memory on Desktop" · 0ceffaa2
    Thomas Anderson authored
    This reverts commit 3558d80a.
    
    Reason for revert: Suspected cause of build failure on android-official:
    
    https://ci.chromium.org/p/chromium/builders/ci/android-official/1056
    
    [13692/25621] SOLINK ./libaudio_unittests__library.so
    FAILED: libaudio_unittests__library.so libaudio_unittests__library.so.TOC lib.unstripped/libaudio_unittests__library.so lib.unstripped/libaudio_unittests__library.so.map.gz
    /b/s/w/ir/cipd_bin_packages/cpython/bin/python "../../build/toolchain/gcc_solink_wrapper.py" --reade...(too long)
    ld.lld: error: undefined hidden symbol: base::(anonymous namespace)::g_discardable_allocator (.llvm.16724700302094337840)
    >>> referenced by run_all_unittests.cc:0 (../../media/test/run_all_unittests.cc:0)
    >>>               thinlto-cache/llvmcache-3F27182A7CE8A475288094E8A454CB68C4740658:(TestSuiteNoAtExit::Initialize())
    
    Original change's description:
    > Proactively purging discardable memory on Desktop
    > 
    > This CL adds a way for ClientDiscardableSharedMemoryManager to discard
    > unlocked discardable memory locally. To achieve this, it keeps track
    > of all locked and unlocked, unpurged instances. These are then purged
    > all at once when ReleaseFreeMemory() is called.
    > 
    > This is guarded by a new feature which is disabled by default, and as
    > such there is no behaviour change by default.
    > 
    > Bug: 1109209
    > Change-Id: I7755d714ff354e831557627fda401751384392b8
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321400
    > Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com>
    > Reviewed-by: Peng Huang <penghuang@chromium.org>
    > Reviewed-by: Benoit L <lizeb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#798630}
    
    TBR=penghuang@chromium.org,lizeb@chromium.org,thiabaud@google.com
    
    Change-Id: I39ddd002be3753d1339501c74df866d898ad53a4
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1109209
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360121Reviewed-by: default avatarThomas Anderson <thomasanderson@chromium.org>
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#798796}
    0ceffaa2
BUILD.gn 610 Bytes