• Josh Simmons's avatar
    Fixing several issues in the Translate tests to make them less flakey. · 0d5f2bdb
    Josh Simmons authored
     1) Tests were failing on pie-rel bots because swarmed builds do not
        include API keys. I've updated the tests to set a flag to ignore
        these missing keys.
     2) Tests were still flaking quite a bit due to batching and state not
        being cleared between runs. I've tried a couple things (enabling
        extensive clearing, opening new tabs and closing tabs after tests)
        but the only way I've been able to get them to run without flakes is
        by disabling batching. I'll need to dig into translate internals to
        determine what the right fix is here.
     3) Tests were failing the
        network_service_out_of_process_chrome_public_test_apk phase because,
        while the network monitor _says_ it has a connection to the internet
        during these tests, tests run under this configuration will actually
        refuse to resolve any DNS requests. I've added early returns for
        when the network service is out of process, but longer term I've
        opened crbug/1134812 to track the removal of the internet
        dependency. Similar to #2 this will take digging into Translate
        internals to make them more testable.
    
    BUG=1141160
    
    Change-Id: I4cac8deed71235c2e2da6a6a690edbbaed047b9a
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461711
    Commit-Queue: Josh Simmons <jds@google.com>
    Reviewed-by: default avatarMegan Jablonski <megjablon@chromium.org>
    Reviewed-by: default avatarMichael Thiessen <mthiesse@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#819660}
    0d5f2bdb
translate_bridge.cc 16.2 KB