• Aga Wronska's avatar
    Fix parent access code validation for reauth · 0d9923f4
    Aga Wronska authored
    This change addresses two problems with parent access code
    on login screen.
    1. When doing reauth we should validate parent code against
    all configurations that are available on device. We enforce
    parent code when the device is owned by child, event if it
    is different user going through reauth.
    It will fix https://crbug.com/1140310.
    2. IsDeviceOwnedByChild is causing a crash when the device
    owner cannot be found on user list. While I cannot reproduce
    such situation, it seems that either stored device owner id
    is incorrect or we fail at reading users list from Local State.
    Relaxing the owner check and defaulting to false will prevent
    crash while we investigate the problem further.
    It is a speculative fix for https://crbug.com/1140357.
    
    Bug: 1140310, 1140357
    
    Change-Id: I3d4afab92741d90cae768f58b0da831f0c6c163a
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490855Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
    Reviewed-by: default avatarDenis Kuznetsov [CET] <antrim@chromium.org>
    Commit-Queue: Aga Wronska <agawronska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#822273}
    0d9923f4
parent_access_controller_impl.cc 7.05 KB