• Kunihiko Sakamoto's avatar
    Revert "Reland "Ensure UI Automation GetFocus reaches focused node in web content"" · 0d9c2e89
    Kunihiko Sakamoto authored
    This reverts commit a471ff9b.
    
    Reason for revert: DumpAccessibilityEventsTest.AccessibilityEventsMenuListCollapse* are still flaking on Win7 bots.
    https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/100813
    https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/65070
    
    Original change's description:
    > Reland "Ensure UI Automation GetFocus reaches focused node in web content"
    > 
    > This is a reland of 756820dd
    > 
    > The original CL was reverted due to test failures on Win7.
    > 
    > On both Win10 and Win7, UI Automation was generating an initial focus
    > event when the test listener first connects. On Win10, this initial
    > focus event comes from a window managed by the operating system
    > (ClassName=ApplicationManager_ImmersiveShellWindow). Since that element
    > is outside the scope of the test app, the test listener throws it out.
    > On Win7, the initial focus event comes from an element in our web
    > content, so the test listener logs it.
    > 
    > My suspicion is that the difference in behavior is due to mitigations
    > for focus stealing introduced between Win7 and Win10. Regardless, the
    > fix is to generate separate expectation files for Win7.
    > 
    > Original change's description:
    > > Ensure UI Automation GetFocus reaches focused node in web content
    > >
    > > AXPlatformNodeDelegate::GetFocus() returns the node within the called
    > > node's subtree that currently has focus. When an element in web content
    > > has focus, and a delegate in Views is asked for focus, that delegate can
    > > only reach as far as the web content root. Calling GetFocus() again on
    > > the web content root ensures that the platform API returns the currently
    > > focused node.
    > >
    > > Bug: 928811
    > > Change-Id: Ice47eed0a8ea4281beb48624942ac2428fb1950f
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099162
    > > Reviewed-by: Ian Prest <iapres@microsoft.com>
    > > Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
    > > Cr-Commit-Position: refs/heads/master@{#749386}
    > 
    > Bug: 928811
    > Change-Id: I32e59febfb6dbb7b5386c155c252c880a0f2ebc5
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101930
    > Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
    > Reviewed-by: Ian Prest <iapres@microsoft.com>
    > Cr-Commit-Position: refs/heads/master@{#750781}
    
    TBR=kbabbitt@microsoft.com,iapres@microsoft.com
    
    Change-Id: I064dad632ef4379f6132e4d1a2f17bd558e8293e
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 928811
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105691Reviewed-by: default avatarKunihiko Sakamoto <ksakamoto@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#750895}
    0d9c2e89
ax_fragment_root_win.cc 10.8 KB