• Mike Wittman's avatar
    [Sampling profiler] Rationalize release/channel config · 0daa79d2
    Mike Wittman authored
    Updates the ThreadProfiler configuration to consider a build to be a
    Chrome release if it's official and Chrome branded. The existing code
    only considered the Chrome branded state which is overly lenient. For
    what its worth breakpad uses the same conditions for whether it should
    be enabled.
    
    This changes behavior of edge cases as follows:
    
    Unofficial Chrome branded builds are now considered to be
    development/CQ builds and as such the profiler is always enabled
    for them.
    
    Official Chrome branded builds with unknown channel are no longer
    treated as development/CQ builds, so the profiler is disabled for
    them rather than always enabled.
    
    Bug: 1129939
    Change-Id: I52b2120ef98734278ffd211809463c2ded3d3bd0
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432386
    Commit-Queue: Mike Wittman <wittman@chromium.org>
    Reviewed-by: default avatarEtienne Pierre-Doray <etiennep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#812417}
    0daa79d2
thread_profiler_platform_configuration.cc 8.51 KB