• kylechar's avatar
    Reland "Add in-process VizCompositorThread for software compositing." · 0dad9bc7
    kylechar authored
    This reverts commit 2b20bcdd.
    
    Reason for revert: Relanding after reverting https://crrev.com/c/1156998.
    
    Original change's description:
    > Revert "Add in-process VizCompositorThread for software compositing."
    >
    > This reverts commit 7d8b7c2d.
    >
    > Reason for revert: Need to revert https://crrev.com/c/1156998
    >
    > Original change's description:
    > > Add in-process VizCompositorThread for software compositing.
    > >
    > > We are having issues where starting a GPU process consistently fails on
    > > some systems. Currently OOP-D runs the display compositor in the GPU
    > > process always. This includes when both hardware acceleration and
    > > SwiftShader are disabled. If we can't start the GPU process, we can't
    > > run the display compositor and Chrome crashes.
    > >
    > > This CL changes where the VizCompositorThread runs if the GPU access is
    > > disabled on Windows. We start the thread after giving up on the GPU
    > > process and create FrameSinkManagerImpl + dependencies on it.
    > >
    > > Also fix chrome://gpu page so that OOP-D and surface sync features are
    > > still correct if |gpu_access_blocked| is true.
    > >
    > > There is a lot of peripheral cleanup and code reuse possible as a follow
    > > up to this CL. It's not attempted here to make this easier to merge back
    > > to M69.
    > >
    > > Bug: 849639
    > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    > > Change-Id: Ica6a3ec5b0e7951cb6807b135df4b4cfe410e394
    > > Reviewed-on: https://chromium-review.googlesource.com/1158723
    > > Reviewed-by: Antoine Labour <piman@chromium.org>
    > > Commit-Queue: kylechar <kylechar@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#580241}
    >
    > TBR=sadrul@chromium.org,kylechar@chromium.org,piman@chromium.org
    >
    > Change-Id: I00fc978561630ef292436e2d44012a0931551d0f
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 849639
    > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    > Reviewed-on: https://chromium-review.googlesource.com/1161121
    > Reviewed-by: kylechar <kylechar@chromium.org>
    > Commit-Queue: kylechar <kylechar@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#580264}
    
    TBR=piman@chromium.org
    
    Change-Id: I6beb00a3551800cae159e503e5dcb5be9a45116e
    Bug: 849639
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    Reviewed-on: https://chromium-review.googlesource.com/1161122
    Commit-Queue: kylechar <kylechar@chromium.org>
    Reviewed-by: default avatarkylechar <kylechar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#580390}
    0dad9bc7
BUILD.gn 14.7 KB