• Marc Treib's avatar
    Cleanup: Remove HttpPostProviderFactor::Init() · 0df8aa40
    Marc Treib authored
    It didn't actually initialize anything, it was just used to pass in the
    user agent string. Might as well pass that into the ctor, and remove
    some plumbing.
    
    The original reason for this two-step initialization was apparently to
    move construction of the Sync user agent string off the UI thread.
    However, (a) even before this CL, the user agent string was in fact
    constructed on the UI thread, and (b) nothing in MakeUserAgentForSync
    looks like it could actually block.
    
    Bug: 951350
    Change-Id: I691f85468988d27187dbfc9088020e10a875fd79
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913258
    Commit-Queue: Marc Treib <treib@chromium.org>
    Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#715254}
    0df8aa40
test_http_bridge_factory.h 1.62 KB