• guohui@chromium.org's avatar
    Make sure sync setup completes when signing in from the avatar bubble with modal warnings · 0eec43ec
    guohui@chromium.org authored
    When signing in from the new avatar bubble, since the inline template has no "choose what to sync" link, thus Chrome shows an inline confirmation in the avatar bubble upon signin completes and blocks sync until the bubble is closed.
    
    However, when some modal warnings show up before signin completes, they steal the focus thus the avatar bubble wont be able to show confirmation for sync settings and sync will be blocked infinitely.
    
    A temporary workaround is to just start sync immediately if a modal warning is shown, since in all cases the dialog mentions that user data will be synced.
    
    I will add a sync settings link to all modal dialogs later so that user could configure sync settings before sync starts.
    
    BUG=435423005
    
    Review URL: https://codereview.chromium.org/447883002
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288122 0039d316-1c4b-4281-b951-d872f2087c98
    0eec43ec
one_click_signin_helper.cc 62.9 KB