• Ian Kilpatrick's avatar
    [LayoutNG] Fix shape-outside-{circle-048,polygon-020}.html tests. · 0f4ea08c
    Ian Kilpatrick authored
    This was two subtle bugs in one.
    
    1) We need to copy back data to the ShapeOutsideInfo side
       data-structure, even if its an "intermediate" layout, (during the
       min/max pass).
    
       This was causing the incorrect size to be calculated for body, as
       it thought the shape was "empty" (its size was 0,0).
    
       Eventually this should be fixed by moving the shape to the layout
       result, removing this side data-structure.
    
    2) The static-position for vertical-rl was broken.
       When accounting for flipped-blocks, we need to use the containing
       block writing-mode, instead of the direct parent.
    
       Static position doesn't really work cross writing modes in the
       existing layout system, so this isn't perfect, is closer to the old
       system.
    
    Bug: 635619
    Change-Id: Ia7f8144cc1c9515b161bf3502c58fee66e59f3c3
    Reviewed-on: https://chromium-review.googlesource.com/c/1315390
    Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
    Reviewed-by: default avatarAleks Totic <atotic@chromium.org>
    Reviewed-by: default avatarMorten Stenshorne <mstensho@chromium.org>
    Reviewed-by: default avatarChristian Biesinger <cbiesinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#605345}
    0f4ea08c
enable-blink-features=LayoutNG 36.6 KB