• Koji Ishii's avatar
    Fix blink.natvis for String and NGFragmentItem · 0fa46be8
    Koji Ishii authored
    This patch fixes following issues in blink.natvis:
    1. Fix the incorrect condition for the "bare" view of
       |StringImpl|.
    2. Fix the order of `<DisplayString>` for |StringImpl|.
       The `<DisplayString>` element without `Condition` must come
       the last, causing a warning message when natvis diagnostic
       message is enabled.
    3. At some point VisualStudio stopped displaying anonymous
       union, and that the natvis failed to display
       |NGFragmentItem|. Removed members of the anonymous union,
       instead, added |Type| and a few other members.
    
    Checked with natvis diagnostic message turned on.
    
    Change-Id: I25cebc1695434d712d7d5a1a816ae272120d6abb
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467503Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
    Reviewed-by: default avatarBruce Dawson <brucedawson@chromium.org>
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#816912}
    0fa46be8
blink.natvis 12.8 KB