GitLab

Before this change, the reason behind an error that happened in
WebController was always lost, as all methods would return a boolean,
either true or false. This makes it hard to debug errors, as many
different errors end up being reported as OTHER.

With this change, the WebController methods can return a
ProcessedActionStatusProto, which ends up being included into the RPC
response, in most case, allowing WebController to let the server know
whether the error failed because the element was not found, or for other
reasons.

This change also add new client status code, which correspond to errors
in WebController.

This change introduces a ClientStatus C++ type, which is, for now, just
a wrapper for ProcessedActionStatusProto. This prepares the way for
adding more debugging information into the status, which can be
forwarded to the server, such as details about clicks.

BUG=b/129387787

Change-Id: I9df154f51401aa52a84d6b8c80c6c7ad02dc61c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543772
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#646241}