• Nico Weber's avatar
    mb: Disallow gn `data` entries that refer to directories in the build directory · 0fd01676
    Nico Weber authored
    `data` entries that are directories are fine for directories in the source
    tree, but in the build tree they cause incorrect incremental builds:
    Consider a build step that copies a bunch of files into the build out dir.
    At a later revision, it copies fewer files. Incremental bots will still have
    the now-removed file sitting around, and due to the listed directory,
    the stale file will be zipped up and sent to swarming.
    
    For now, enable this check only on non-cros non-msan linux, on fuchsia,
    and on iOS.
    
    Add temporary whitelist entries for existing violations. (See patch set
    17 for how some of them can be removed, but I'd like to land those in
    separate CLs.)
    
    Bug: 912946
    Change-Id: Ia01d8e43f0256e3fcae39cb3e1529084d587bb7f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764392
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Reviewed-by: default avatarTakuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#690235}
    0fd01676
mb_unittest.py 26.3 KB