• Denis Bessonov's avatar
    Revert "Fix 0,0-0x0 turning into PaintOp::kUnsetRect." · 0fde9a92
    Denis Bessonov authored
    This reverts commit 0156c949.
    
    Reason for revert: series of review fixes resulted in a no-op code. The completely different approach should be used to fix the bug correctly.
    
    Original change's description:
    > Fix 0,0-0x0 turning into PaintOp::kUnsetRect.
    >
    > When a paint chunk having 0,0-0x0 rect is processed inside an effect, an early
    > return prevents the effect_bounds_stack_.back() update in a
    > ConversionContext::UpdateEffectBounds call. This results in keeping default
    > PaintOp::kUnsetRect in SaveLayerOp::bounds instead of 0,0-0x0 rect.
    >
    > This is probably a reason for a related bug 918240 (see bug thread Comment 4 for
    > details). Application of this patch fixes the lagging print preview.
    >
    > R=​fmalita@chromium.org, samans@chromium.org
    >
    > Bug: 918240
    > Change-Id: I022ae01418e83184421cff7e22566228a2f7c6d3
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1396958
    > Commit-Queue: Denis Bessonov <dbessonov@yandex-team.ru>
    > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#714293}
    
    Bug: 918240
    Change-Id: I89a55d39a53559b37168b91adf3f331dbbf8b106
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007409
    Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
    Auto-Submit: Denis Bessonov <dbessonov@yandex-team.ru>
    Reviewed-by: default avatarXianzhu Wang <wangxianzhu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#733491}
    0fde9a92
display_item_list.h 9.06 KB