• Yuke Liao's avatar
    Reland "[lacros] Make test runner supports lacros_chrome_browsertests" · 10317f04
    Yuke Liao authored
    This reverts commit 48522640.
    
    Reason for revert: During the refactoring, 'os.listdir' was somehow
    accidentally changed to 'list', which resulted in the test failures,
    and this CL fixes the problem.
    
    Original change's description:
    > Revert "[lacros] Make test runner supports lacros_chrome_browsertests"
    >
    > This reverts commit e4eacd09.
    >
    > Reason for revert: Suspect for lacros test failures:
    > https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/2227
    > The only lacros-related change in diff with the previous success run.
    >
    > Original change's description:
    > > [lacros] Make test runner supports lacros_chrome_browsertests
    > >
    > > This CL makes test runner supports lacros_chrome_browsertests by:
    > > 1. Appending necessary args to establish mojo connections.
    > > 2. Always use '--test-launcher-jobs=1' to run tests serially because
    > >    multiple clients crosapis are still not supported yet.
    > >
    > > Bug: 1120582
    > > Change-Id: I865ace26aa4a86c83912c6660bc433d79e43ef76
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410350
    > > Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
    > > Reviewed-by: Erik Chen <erikchen@chromium.org>
    > > Reviewed-by: Sven Zheng <svenzheng@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#806903}
    >
    > TBR=erikchen@chromium.org,liaoyuke@chromium.org,svenzheng@chromium.org
    >
    > Change-Id: Ie630ade531428e78718127792c4f6ab6b0d55025
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 1120582
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410246
    > Reviewed-by: Sergey Poromov <poromov@chromium.org>
    > Commit-Queue: Sergey Poromov <poromov@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#806980}
    
    TBR=erikchen@chromium.org,poromov@chromium.org,liaoyuke@chromium.org,svenzheng@chromium.org
    
    # Not skipping CQ checks because this is a reland.
    
    Bug: 1120582
    Change-Id: Ifaa2235a0a4f9ce8deb9aea5011eda0924e1f051
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412253
    Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
    Reviewed-by: default avatarYuke Liao <liaoyuke@chromium.org>
    Reviewed-by: default avatarErik Chen <erikchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#807111}
    10317f04
test_runner_test.py 6.79 KB