• Adam Rice's avatar
    WebSocket over HTTP/2 clean close fix · 1031e329
    Adam Rice authored
    If an HTTP/2 WebSocket server closed a stream with no error there it
    would trigger a DCHECK in WebSocketSpdyStreamAdapter::OnClose, due to an
    assumption that this method would not be called with an OK status.
    
    Accept the OK status and translate it into an ERR_CONNECTION_CLOSED.
    
    Also add a unit test for this condition.
    
    BUG=1139140
    
    Change-Id: Iaa25ba45606f388d15b377154a6d2273d006fb01
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489104
    Commit-Queue: Adam Rice <ricea@chromium.org>
    Reviewed-by: default avatarBence Béky <bnc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#819714}
    1031e329
websocket_basic_stream_adapters.cc 5.81 KB