• Greg Thompson's avatar
    Revert "[Jobs]: Convert test launcher to using jobs." · 1035e3e0
    Greg Thompson authored
    This reverts commit f533db5c.
    
    Reason for revert: Breaks sequential running of PRE_ tests. See, for example, ChromeTracingDelegateBrowserTestOnStartup.StartupTracingThrottle failures in https://ci.chromium.org/p/chromium/builders/ci/Linux%20ASan%20LSan%20Tests%20(1)/82236. Each PRE_* test must run to completion before the next one is started.
    
    Original change's description:
    > [Jobs]: Convert test launcher to using jobs.
    >
    > Test launcher relies on the fact that TaskScheduler won't have more
    > concurrency than max_tasks to control |num_parallel_jobs|. The
    > TaskScheduler is allowed to run more tasks concurrently than
    > |max_tasks| when some of these tasks are blocked.
    > This CL converts Test launcher to using Jobs and ensures that
    > |runner_count_| concurrency is respected.
    >
    > Bug: 905788
    > Change-Id: Ia090271e11b322140da1bf7e1526f4ba16bfb524
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414556
    > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
    > Reviewed-by: François Doray <fdoray@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#812145}
    
    TBR=fdoray@chromium.org,etiennep@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 905788
    Change-Id: I82463e729c7be1bd7dc5d73ba90b1715f7d9bba8
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445013Reviewed-by: default avatarGreg Thompson <grt@chromium.org>
    Commit-Queue: Greg Thompson <grt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#813138}
    1035e3e0
test_launcher.cc 68.3 KB