• arv's avatar
    Revert of Removing X11 native_event uses for key events. (patchset #7... · 1125c116
    arv authored
    Revert of Removing X11 native_event uses for key events. (patchset #7 id:180001 of https://codereview.chromium.org/479873002/)
    
    Reason for revert:
    Broke Android Tests (dbg)
    
    C  427.575s Main  [FAIL] org.chromium.content.browser.input.ImeTest#testKeyCodesWhileComposingText:
    C  427.575s Main  junit.framework.AssertionFailedError
    C  427.575s Main  	at org.chromium.content.browser.input.ImeTest.assertUpdateStateCall(ImeTest.java:694)
    C  427.575s Main  	at org.chromium.content.browser.input.ImeTest.testKeyCodesWhileComposingText(ImeTest.java:410)
    C  427.575s Main  	at java.lang.reflect.Method.invokeNative(Native Method)
    C  427.575s Main  	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
    C  427.575s Main  	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
    C  427.575s Main  	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
    C  427.575s Main  	at org.chromium.content_shell_apk.ContentShellTestBase.runTest(ContentShellTestBase.java:227)
    C  427.575s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
    C  427.575s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
    C  427.575s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
    C  427.575s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
    
    Original issue's description:
    > Removing uses of X11 native key events.
    >
    > BUG=380349
    >
    > Committed: https://chromium.googlesource.com/chromium/src/+/bbb7ea7c66f18298079eea4a6b24834986f4a822
    >
    > Committed: https://chromium.googlesource.com/chromium/src/+/13d90b146a400156427243d05159cadd8d72c0b9
    
    TBR=sadrul@chromium.org,sky@chromium.org,erg@chromium.org,jamesr@chromium.org,boliu@chromium.org,kpschoedel@chromium.org
    NOTREECHECKS=true
    NOTRY=true
    BUG=380349
    
    Review URL: https://codereview.chromium.org/548303003
    
    Cr-Commit-Position: refs/heads/master@{#293732}
    1125c116
content_browser.gypi 92.5 KB