• Pâris MEULEMAN's avatar
    Merge SigninManagerDelegate back into SigninManager · 11320f06
    Pâris MEULEMAN authored
    This merges back SigninManagerDelegate.java into SigninManager.java and
    likewise for c++ code. This is in the scope of a change of strategy
    regarding the identityManager implementation on Android, using a
    layering strategy similar to what was done on iOS.
    
    The change consist in:
    * copy chrome_signin_manager_delegate.* methods to
      signin_manager_android.*
    * rename occurrences of ChromeSigninManagerDelegate to
      SigninManagerAndroid, in Java including JNI invocations and C++.
    * Directly invoke methods instead of calling mDelegate (java)
    * Update constructors to include the delegate dependencies.
    
    * A significant change that is not an obvious code move is the rollback of
      SigninManagerAndroid's constructor using
      SigninClient/PrefService(local_state) to Profile. This makes the
      remainder of the change much simpler, but does cascade to the factory.
    
    The above changes are described in their files in PS3:
    crrev.com/c/1700210/3
    
    Change-Id: I1b0de2129f3df649fa56d50b8dd191e8e1bb30ab
    Bug: 985256
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700210
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: default avatarColin Blundell <blundell@chromium.org>
    Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
    Reviewed-by: default avatarBoris Sazonov <bsazonov@chromium.org>
    Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#681349}
    11320f06
BUILD.gn 112 KB