• Bruce Dawson's avatar
    Revert "Fix Windows sandbox to work with Application Verifier" · 1155ea4b
    Bruce Dawson authored
    This reverts commit da69db99.
    
    Reason for revert: Suspected of causing the crashes tracked by crbug.com/814641
    
    Original change's description:
    > Fix Windows sandbox to work with Application Verifier
    > 
    > Application Verifier is a useful tool for tracking down bugs on Windows.
    > However Chrome's sandbox has not played well with App Verifier - it ends
    > up initializing a heap before the process is ready for this. This change
    > teaches the NtMapViewOfSection to skip InitHeap when handling the App
    > Verifier DLLs, which don't need patching anyway.
    > 
    > With this change I can run Chrome with the default App Verifier settings
    > enabled with the exception of Handles and TLS (those failures probably
    > don't represent real bugs), without using --no-sandbox.
    > 
    > Bug: 752344
    > Change-Id: Id1fd4be9c0f080513bbdb649ed5cf2637df8474c
    > Reviewed-on: https://chromium-review.googlesource.com/925821
    > Reviewed-by: James Forshaw <forshaw@chromium.org>
    > Reviewed-by: Will Harris <wfh@chromium.org>
    > Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#538307}
    
    TBR=brucedawson@chromium.org,forshaw@chromium.org,wfh@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 752344
    Change-Id: Icd8feea1779f2891389762db0773ecf0ed9ad762
    Reviewed-on: https://chromium-review.googlesource.com/934862Reviewed-by: default avatarBruce Dawson <brucedawson@chromium.org>
    Reviewed-by: default avatarWill Harris <wfh@chromium.org>
    Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#538851}
    1155ea4b
sandbox_nt_util.h 7.03 KB